Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can axum::serve handle both http 1 and 2? #1953

Closed
davidpdrsn opened this issue Apr 21, 2023 · 5 comments · Fixed by #2241
Closed

Can axum::serve handle both http 1 and 2? #1953

davidpdrsn opened this issue Apr 21, 2023 · 5 comments · Fixed by #2241
Assignees
@rakshith-ravi
Labels
A-axum
Milestone
0.7

Comments

@davidpdrsn
Copy link
Member

axum::Server was a re-export of hyper::Server which is going away for hyper 1.0. Therefore axum is getting axum::serve(tcp_listener, service) in 0.7 for simple use cases.

It currently only supports http 1. We should investigate if we can also support http 2. Might require hyperium/hyper-util#11
@davidpdrsn davidpdrsn added this to the 0.7 milestone Apr 21, 2023
@davidpdrsn davidpdrsn added S-blocked Status: marked as blocked ❌ on something else such as a PR or other implementation work. A-axum labels Apr 21, 2023
@programatik29
Copy link
Contributor

It should be possible when the PR is merged.

@rakshith-ravi
Copy link
Contributor

Looks like that got merged. Is this something we can do now? Can I help in any way?

@davidpdrsn
Copy link
Member Author

Great! I'm curious if we can just replace the implementation of axum::serve to instead be a small wrapper around something in hyper-util. That was always the intention. Would be much appreciated if you'd give that a shot!

@davidpdrsn davidpdrsn removed the S-blocked Status: marked as blocked ❌ on something else such as a PR or other implementation work. label Sep 26, 2023
@rakshith-ravi
Copy link
Contributor

@rustbot claim

@rakshith-ravi
Copy link
Contributor

No rustbot? Lol okay. Force of habit I guess

@rakshith-ravi rakshith-ravi mentioned this issue Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakshith-ravi rakshith-ravi

Labels
A-axum
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

Add HTTP/1 and HTTP/2 to axum::serve rakshith-ravi/axum
3 participants
@davidpdrsn @rakshith-ravi @programatik29