Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain sequence of bytes can screw up the channel #19

Open
jupyterkat opened this issue Oct 29, 2022 · 2 comments
Open

Certain sequence of bytes can screw up the channel #19

jupyterkat opened this issue Oct 29, 2022 · 2 comments

Comments

@jupyterkat
Copy link

I feel like this should be documented somewhere, if you happen to send some bytes that matches the header of yaque, then the queue may cease to function. Happened when I tried to get some messagepack through the channel.

@tokahuke
Copy link
Owner

tokahuke commented Oct 31, 2022

Hum... interesting stuff. If I remember correctly, I have accounted for that on one of the versions. Which version are you using exactly?

If this error is on the current version, it should be corrected, not documented.

EDIT: I would also greatly appreciate an example code so that I can use it as unittest. 😄

@jupyterkat
Copy link
Author

jupyterkat commented Oct 31, 2022

This is on latest, you can probably get this by serializing with rmp_serde::to_vec() on some structs. I haven't found the exact struct that broke it, since many was in there. But here is the struct in question
https://github.com/jupyterkat/BYONDDiffBots/blob/78fba9b1a7e0cbc173a12b949991b65dc13302b4/crates/diffbot_lib/src/job/types.rs#L15
Serialized here (switched to json because it works atm):
https://github.com/jupyterkat/BYONDDiffBots/blob/78fba9b1a7e0cbc173a12b949991b65dc13302b4/crates/mapdiffbot2/src/github_processor.rs#L106
The behaviour is that it keeps stuck on waiting for some bytes that never come to the recv end when the job is sent into the queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants