You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like the '/search' endpoint is broken and instead of requesting http://giantbomb.com/api/search? it goes to http://giantbomb.com/search which in turn returns HTML instead of JSON.
I wanted to make a pull request but I'm not sure this is the proper way to fix this. Maybe we need to understand why GiantBombApi::Request::Search doesn't use API_URL when making a request instead of hardcoding the full URL in the class.
I tried to have a look through the code but to be honest it's a bit complicated for me and I don't really have the time to properly learn how it works.
Thanks
The text was updated successfully, but these errors were encountered:
Hey,
It looks like the '/search' endpoint is broken and instead of requesting
http://giantbomb.com/api/search?
it goes tohttp://giantbomb.com/search
which in turn returns HTML instead of JSON.I managed to fix this with:
I wanted to make a pull request but I'm not sure this is the proper way to fix this. Maybe we need to understand why
GiantBombApi::Request::Search
doesn't useAPI_URL
when making a request instead of hardcoding the full URL in the class.I tried to have a look through the code but to be honest it's a bit complicated for me and I don't really have the time to properly learn how it works.
Thanks
The text was updated successfully, but these errors were encountered: