Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'/search' endpoint broken #5

Open
pacMakaveli opened this issue Oct 12, 2017 · 0 comments
Open

'/search' endpoint broken #5

pacMakaveli opened this issue Oct 12, 2017 · 0 comments
Assignees

Comments

@pacMakaveli
Copy link

pacMakaveli commented Oct 12, 2017

Hey,

It looks like the '/search' endpoint is broken and instead of requesting http://giantbomb.com/api/search? it goes to http://giantbomb.com/search which in turn returns HTML instead of JSON.

I managed to fix this with:

    def end_point
      GiantBombApi::Client::API_URL + 'search'
    end

I wanted to make a pull request but I'm not sure this is the proper way to fix this. Maybe we need to understand why GiantBombApi::Request::Search doesn't use API_URL when making a request instead of hardcoding the full URL in the class.

I tried to have a look through the code but to be honest it's a bit complicated for me and I don't really have the time to properly learn how it works.

Thanks

@toadle toadle self-assigned this Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants