Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable error variances of more than 16 #119

Open
tlepoint opened this issue Sep 6, 2022 · 0 comments
Open

Enable error variances of more than 16 #119

tlepoint opened this issue Sep 6, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers rust Pull requests that update Rust code

Comments

@tlepoint
Copy link
Owner

tlepoint commented Sep 6, 2022

The variance for sampling according to the centered binomial distribution is currently capped at 16:

pub fn sample_vec_cbd(vector_size: usize, variance: usize) -> Result<Vec<i64>, &'static str> {
	if !(1..=16).contains(&variance) {
		return Err("The variance should be between 1 and 16");
	}

It would be good to enable larger values.

@tlepoint tlepoint added enhancement New feature or request good first issue Good for newcomers rust Pull requests that update Rust code labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

1 participant