Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precalculate commonly used values #3

Open
tkoz0 opened this issue Dec 17, 2022 · 0 comments
Open

Precalculate commonly used values #3

tkoz0 opened this issue Dec 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@tkoz0
Copy link
Owner

tkoz0 commented Dec 17, 2022

Some values are commonly used in variations, in particular, flam3 precalculates the following

  • atan(x,y)
  • atan(y,x)
  • sin(atan(x,y))
  • cos(atan(x,y))
  • sqrt(x*x+y*y)
  • x*x+y*y

This change may have performance consequences so it should be tested well.

See what flam3 does here: https://github.com/scottdraves/flam3/blob/7fb50c82e90e051f00efcc3123d0e06de26594b2/variations.c#L2152-L2170

@tkoz0 tkoz0 added the enhancement New feature or request label Dec 17, 2022
@tkoz0 tkoz0 self-assigned this Dec 17, 2022
@tkoz0 tkoz0 removed their assignment Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant