Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@turnkey/http: TurnkeyClient should return an error when config.baseUrl is empty #124

Closed
r-n-o opened this issue Sep 28, 2023 · 1 comment

Comments

@r-n-o
Copy link
Contributor

r-n-o commented Sep 28, 2023

We should validate that config.baseUrl is not empty before constructing a client. Otherwise other downstream errors will happen: we can't fetch a relative path.

Here's the line in question:

@andrewkmin
Copy link
Collaborator

addressed via #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants