From 4428decb4f093382643ff16fff235271760da15d Mon Sep 17 00:00:00 2001
From: Zeke Mostov <zeke@turnkey.io>
Date: Mon, 6 May 2024 20:17:38 -0400
Subject: [PATCH] respond to some feedback

---
 src/qos_client/RESHARD_GUIDE.md               | 6 +++---
 src/qos_core/src/protocol/services/reshard.rs | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/qos_client/RESHARD_GUIDE.md b/src/qos_client/RESHARD_GUIDE.md
index c7fa4489b..3cc9b1fb4 100644
--- a/src/qos_client/RESHARD_GUIDE.md
+++ b/src/qos_client/RESHARD_GUIDE.md
@@ -41,7 +41,7 @@ qos_client boot-reshard \
 
 ### 3 - Get attestation doc (Old Share Holder)
 
-Get the attestation doc from the enclave. The attestation doc contains a refference to the reshard input and the ephemeral key which shares will be encrypted.
+Get the attestation doc from the enclave. The attestation doc contains a reference to the reshard input and the ephemeral key which shares will be encrypted.
 
 ```sh
 qos_client get-reshard-attestation-doc \
@@ -62,7 +62,7 @@ For each quorum key being resharded, the user will need a separate directory wit
   - my_alias.share
 ```
 
-Note that the logic looks at the extension of the file to determine if its a share or the quorum key.
+Note that the logic looks at the extension of the file to determine if it's a share or the quorum key.
 
 ```sh
 qos_client reshard-re-encrypt-share \
@@ -84,7 +84,7 @@ Post the re-encrypted shares from last step in order to reconstruct the quorum k
 
 ```sh
 qos_client reshard-post-share
-  --provision-input-path <write: path to the file to write this users provision input> \
+  --provision-input-path <write: path to the file to write this users ReshardProvisionInput> \
   --host-port 3001 \
   --host-ip localhost
 ```
diff --git a/src/qos_core/src/protocol/services/reshard.rs b/src/qos_core/src/protocol/services/reshard.rs
index 959c9a3bd..46fa015b3 100644
--- a/src/qos_core/src/protocol/services/reshard.rs
+++ b/src/qos_core/src/protocol/services/reshard.rs
@@ -74,9 +74,9 @@ pub struct ReshardProvisionInput {
 pub struct ReshardInput {
 	/// List of quorum public keys
 	pub quorum_keys: Vec<Vec<u8>>,
-	/// The set and threshold to shard the key.
+	/// The share set and threshold to shard the quorum keys to.
 	pub new_share_set: ShareSet,
-	/// The set the key is currently sharded too.
+	/// The share set the quorum keys are currently sharded too.
 	pub old_share_set: ShareSet,
 	/// The expected configuration of the enclave. Useful to verify the
 	/// attestation document against. We also want those posting shares to
@@ -289,7 +289,7 @@ pub(in crate::protocol) fn reshard_provision(
 				reshard_input.new_share_set.threshold as usize,
 			);
 
-			// Now, lets create the new shards
+			// Now, let's create the new shards
 			let member_outputs =
 			zip(shares, reshard_input.new_share_set.members.iter().cloned())
 				.map(|(share, share_set_member)| -> Result<GenesisMemberOutput, ProtocolError> {