Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prettify ✨ #50

Merged
merged 2 commits into from
Aug 9, 2024
Merged

prettify ✨ #50

merged 2 commits into from
Aug 9, 2024

Conversation

andrewkmin
Copy link
Contributor

@andrewkmin andrewkmin commented Aug 8, 2024 •
edited
Loading

$title

@r-n-o
Copy link
Collaborator

r-n-o commented Aug 8, 2024

Looks good besides the merge conflicts to resolve :)

@andrewkmin andrewkmin mentioned this pull request Aug 8, 2024
Open
@socket-security Socket Security
Copy link

socket-security bot commented Aug 8, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem, unsafe 0 11.2 MB prettier-bot

View full report↗︎

@andrewkmin
Copy link
Contributor Author

Looks good besides the merge conflicts to resolve :)

resolved!

r-n-o
r-n-o reviewed Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@r-n-o r-n-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to exclude noble-ed25519.js and noble-hashes.js from the list of linted files: they're vendored in.

r-n-o
r-n-o approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@r-n-o r-n-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that though: looks good, only whitespace changes, so no reason to block 👍

@andrewkmin andrewkmin merged commit f76b539 into main Aug 9, 2024
6 checks passed
@andrewkmin andrewkmin deleted the andrew/prettify branch August 9, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-n-o r-n-o r-n-o approved these changes

@omkarshanbhag omkarshanbhag Awaiting requested review from omkarshanbhag

@zkharit zkharit Awaiting requested review from zkharit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewkmin @r-n-o