Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin 13 and pin 15 incorrectly sets allow_other_uses: true #7

Open
paularmstrong opened this issue Dec 29, 2023 · 3 comments
Open

pin 13 and pin 15 incorrectly sets allow_other_uses: true #7

paularmstrong opened this issue Dec 29, 2023 · 3 comments

Comments

@paularmstrong
Copy link

Since 2023.12.x, I've been unable to update my esphome firmware with the following error:

INFO ESPHome 2023.12.5
INFO Reading configuration /config/esphome/pauls-standing-desk.yaml...
INFO Detected timezone 'America/Los_Angeles'
Failed config

output.gpio: [source <unicode string>:24]
  
  Pin 13 incorrectly sets allow_other_uses: true.
  platform: gpio
  inverted: True
  id: standing_desk_up_pin
  pin: 
    number: 13
    allow_other_uses: True
    mode: 
      output: True
      input: False
      open_drain: False
      pullup: False
      pulldown: False
      analog: False
    inverted: False
output.gpio: [source <unicode string>:31]
  
  Pin 15 incorrectly sets allow_other_uses: true.
  platform: gpio
  inverted: True
  id: standing_desk_down_pin
  pin: 
    number: 15
    allow_other_uses: True
    mode: 
      output: True
      input: False
      open_drain: False
      pullup: False
      pulldown: False
      analog: False
    inverted: False

Relevant configuration:

substitutions:
  device_name: pauls-standing-desk
  device_friendly_name: Paul’s standing desk
  loglevel: ERROR

packages:
  standing_desk: github://tjhorner/esphome-standing-desk/configs/template.yaml
  desk_config: github://tjhorner/esphome-standing-desk/configs/desks/uplift_v2.yaml
  device_base: !include common/base.yaml

esphome:
  name: "pauls-standing-desk"
  platform: ESP8266
  board: d1_mini
@tjhorner
Copy link
Owner

tjhorner commented Jan 7, 2024

This is due to a change that was made as a result of ESPHome 2023.12: pins that are used in multiple places need to be flagged with allow_other_uses everywhere it's used. The pins that are used in multiple places in the stock Upsy Desky configuration were marked as such here.

But it looks like if they aren't actually used elsewhere and this flag is set, ESPHome will complain. The only way to fix this is to make a custom version of this package or for me to define substitutions for each of the defined pins (which is REALLY ugly). I'm not sure I agree with this design decision from the ESPHome team, so I will raise an issue on their end to see if they can at least introduce a flag to ignore this specific error.

Sorry for the inconvenience.

@paularmstrong
Copy link
Author

Interesting. Thanks for the context! Can you link an issue here if you file one to follow along?

@tjhorner
Copy link
Owner

Finally opened the issue here: esphome/feature-requests#2661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants