Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes Don't Match Grids #88

Open
hilmiyafia opened this issue Jul 29, 2021 · 9 comments
Open

Notes Don't Match Grids #88

hilmiyafia opened this issue Jul 29, 2021 · 9 comments

Comments

@hilmiyafia
Copy link

Hello, I think the notes are smaller than the grids. It match perfectly at the top, but as it goes down, it doesn't move as much as the grid does.

Capture

@titinko
Copy link
Owner

titinko commented Jul 30, 2021

Which version and operating system are you seeing this bug for?

@hilmiyafia
Copy link
Author

hilmiyafia commented Jul 30, 2021

@titinko I run this Utsu from the source I downloaded yesterday. I'm using Windows 10 version 20H2. It seems that the scale is correct when the verticalScale is 1.0 in the DiscreteScaler. Could it be that there's a round-off error somewhere?

@titinko
Copy link
Owner

titinko commented Jul 31, 2021

Thanks for the extra details! Can you give the exact steps to reproduce? Is the scaling broken from the moment you open UTSU on Windows and add some notes, or did you change the zoom or some other setting first?

@hilmiyafia
Copy link
Author

@titinko You're welcome! It is broken the moment I open UTSU and add some notes. You know you can only zoom in 4 times , right? I tried looking at the code at found this line:

public static final ImmutableList<Double> VERTICAL_SCALES = ImmutableList.of(0.85, 1.0, 1.15, 1.3, 1.75);

According to that line, the default scale would be 0.85. Zoom in once, you go to 1.0, zoom in again you go to 1.15, and so on. The problem appears immediately after I open UTSU, but if I zoom in once, the problem is fixed. But if I zoom in again, the problem reappears. So that means, the scaling is off when the vertical scale is not at 1.0. Zooming in and out a few times give consistent results.

@pseudo-producer
Copy link

I'm having a similar problem with the current version 4.5, but I use Linux.

@titinko
Copy link
Owner

titinko commented Oct 27, 2021

Which Linux distribution are you using? I'm not seeing this issue on my Ubuntu 18.04. Scrolled to the bottom and the notes are still in alignment:

Screen Shot 2021-10-26 at 5 55 44 PM

@hilmiyafia
Copy link
Author

hilmiyafia commented Oct 27, 2021

Which Linux distribution are you using? I'm not seeing this issue on my Ubuntu 18.04. Scrolled to the bottom and the notes are still in alignment:

Screen Shot 2021-10-26 at 5 55 44 PM

Hey, the problem has fixed in the latest version! 😁 Thank you @titinko

@pseudo-producer
Copy link

Qual distribuição Linux você está usando? Não estou vendo esse problema no meu Ubuntu 18.04. Rolado para baixo e as notas ainda estão alinhadas:

Captura de tela 2021-10-26 às 5 55 44 PM

Hi! I use a flavor of Ubuntu, which is Ubuntu Studio with KDE Plasma interface, it's in edition 21.04 according to the System information. I rechecked the top problem and realized I was wrong, it's more of a UX problem. I couldn't adapt to the way the piano and the note-taking area were arranged.

@titinko
Copy link
Owner

titinko commented Oct 28, 2021

Looking closely, the notes do seem to be a few pixels down and to the right from what they should be. Not a serious issue since it's only a few pixels, but I can try to move them back in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants