Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONRPC KeyError when result is None #8

Open
daniellibonati opened this issue Jan 2, 2020 · 0 comments · May be fixed by daniellibonati/odooly#1 or #9
Open

JSONRPC KeyError when result is None #8

daniellibonati opened this issue Jan 2, 2020 · 0 comments · May be fixed by daniellibonati/odooly#1 or #9

Comments

@daniellibonati
Copy link

When a JSONRPC call returns None, the response dictionary doesn't contain a 'result' key, therefore it produces a KeyError.
daniellibonati pushed a commit to daniellibonati/odooly that referenced this issue Jan 2, 2020
[FIX] Use resp.get() to prevent KeyError
57a7eb5 
Whenever a JSON RPC call returns `None`, the `result` key in the response will not exist, and therefore it will trigger a KeyError. By using get(), None is returned if the the 'result' key does not exist.

Fixes tinyerp#8
This was referenced Jan 2, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@daniellibonati