Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinkerbell v1alpha2 API #14

Open
chrisdoherty4 opened this issue Dec 27, 2022 · 9 comments
Open

Tinkerbell v1alpha2 API #14

chrisdoherty4 opened this issue Dec 27, 2022 · 9 comments
Assignees
Labels
status/accepted The scope and kind of work is agreed and the item accepted to the backlog theme/refactor Reworking existing code/paradigms

Comments

@chrisdoherty4
Copy link
Member

chrisdoherty4 commented Dec 27, 2022

The Custom Resource Definitions defined in the Tink repository are mapped from the old Postgres backend without thinking too much about the data and organization.

We've identified duplicate and hard to understand fields on CRDs. We would like to refactor the CRDs to better represent the data they contain.

Project
https://github.com/orgs/tinkerbell/projects/26

@chrisdoherty4 chrisdoherty4 converted this from a draft issue Dec 27, 2022
@chrisdoherty4 chrisdoherty4 added the theme/refactor Reworking existing code/paradigms label Dec 27, 2022
@chrisdoherty4 chrisdoherty4 self-assigned this Dec 27, 2022
@chrisdoherty4 chrisdoherty4 moved this from Discussion to Accepted in Tinkerbell Roadmap Dec 27, 2022
@chrisdoherty4
Copy link
Member Author

Needs to take into consideration tinkerbell/tink#198 that claims global timeouts are unsupproted.

@chrisdoherty4
Copy link
Member Author

chrisdoherty4 commented Dec 27, 2022

Take into consideration removal of the in_use flag on the Hardware CRD. Current train of thought is to support a boolean flag indicating the hardware should be netbooted and to strip out in_use entirely. This necessitates some changed in CAPT as it would then be responsible for determining if a piece of hardware has been provisioned already.

@jacobweinstock
Copy link
Member

jacobweinstock commented Dec 27, 2022

Refactor of Hardware CRD should take into account the removal and/or consolidation of duplicate fields like allowPXE, allow_pxe, always_pxe, allowWorkflow.

@chrisdoherty4 chrisdoherty4 added the status/accepted The scope and kind of work is agreed and the item accepted to the backlog label Dec 28, 2022
@chrisdoherty4
Copy link
Member Author

Drop multiple tasks from templates because we no longer support multi-worker workflows. We should explain why tasks are being dropped as part of release notes.

@jacobweinstock
Copy link
Member

Diskless system support was brought up in the community Slack channel (also at KubeCon NA, actually). Part of that request was to have support for always running a workflow. so, anytime this machine boots up the same workflow would be served.
https://cloud-native.slack.com/archives/C01SRB41GMT/p1673924577216179

@chrisdoherty4 chrisdoherty4 moved this from Accepted to In progress in Tinkerbell Roadmap Jan 18, 2023
@jacobweinstock
Copy link
Member

WIP: tinkerbell/proposals#65

@chrisdoherty4
Copy link
Member Author

The design will be re-opened as a PR on the roadmap repository.

@chrisdoherty4 chrisdoherty4 changed the title Refactor Tink CRDs Tinkebrell v1alpha2 API Mar 17, 2023
@chrisdoherty4 chrisdoherty4 changed the title Tinkebrell v1alpha2 API Tinke4bell v1alpha2 API Mar 17, 2023
@chrisdoherty4 chrisdoherty4 changed the title Tinke4bell v1alpha2 API Tinkerbell v1alpha2 API Mar 17, 2023
@chrisdoherty4
Copy link
Member Author

chrisdoherty4 commented Mar 26, 2023

Implementation has begun.

@chrisdoherty4
Copy link
Member Author

chrisdoherty4 commented Nov 14, 2023

A long awaited design has been merged in #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/accepted The scope and kind of work is agreed and the item accepted to the backlog theme/refactor Reworking existing code/paradigms
Projects
Status: In progress
Development

No branches or pull requests

2 participants