Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make jkan social? #112

Open
iltempe opened this issue Apr 28, 2016 · 8 comments
Open

make jkan social? #112

iltempe opened this issue Apr 28, 2016 · 8 comments

Comments

@iltempe
Copy link

iltempe commented Apr 28, 2016

what do you think to make Jkan more social? I mean include the possibility to create community, comments the datasets published. is it a crazy thing?

@jalbertbowden
Copy link

isn't there a plan to implement disqus? i think this is a novel idea, especially allowing signup/in via 3rd party like github/stackoverflow/etc.

@iltempe
Copy link
Author

iltempe commented Apr 29, 2016

yes! disquis should be an idea, I mean, my portal is intended for "normal people" that are not part of governements staff so social should be nice.

@JJediny
Copy link
Contributor

JJediny commented May 6, 2016

There was an issue #5 for adding disqus (which can certainly be done) but there is also already a setting to turn on hypothesis which not only also for threaded conversation but annotation of any content on the site, just change the hypothesis setting in the _config.yml to true:

https://github.com/timwis/jkan/blob/gh-pages/_config.yml#L66

@timwis
Copy link
Owner

timwis commented May 7, 2016

I think adding disqus comments would be a great addition. It also seems pretty straightforward to do. Would anyone like to give it a shot?

@iltempe
Copy link
Author

iltempe commented May 7, 2016

I've added the possibility to make comments with DISQUS on datasets.

It's just a question to set a tag in the dataset md file, "comment: true" and in _config.yml your disqus shortname.

In dataset.html page i've inserted the JS code to enable disqus where comments are enable.

you can look everythig on http://iltempe.github.io/opendatagentediprato/datasets/

you have a pull request on jkan, please verify wich changes you need.

@willemvanopstal
Copy link

@iltempe Looks good with the disquss comment sections.
Can you explain a little bit more on how to incorporate this functionaility?

@matbrgz
Copy link

matbrgz commented May 12, 2018

https://staticman.net has a good approuch about this.. take a look.

@timwis
Copy link
Owner

timwis commented May 12, 2018

Wow that's a pretty cool approach! Feels more jekylly than something like disqus would, which is nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants