Makes the the trading.py example compatible with Python 3.7 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 38bb259.
Added str conversion of siteid
encode utf-8 on string object only
replace 'basestring' with 'str'
Add an option for domain to sample/findings.py so it can work with sandbox keys
Make compatible with python 3
updated trading sample
Revert "Make compatible with python 3"
Python3 compatibility
timotheus
reviewed
Feb 13, 2019
| @@ -30,6 +30,12 @@ | |||
| True: 'https', | |||
| } | |||
|
|
|||
| # Added compatibility for Python 3 | |||
There was a problem hiding this comment.
I thought we had python 3 support covered already. Can you supply breaking test case that your commit is fixing?
There was a problem hiding this comment.
I was getting errors regarding basestring, and it appeared to be trying to .encode("utf-8") a dict. The test case was trying to run the example itself, uploading an image from the filesystem. At least on Mac OS High Sierra. I can reclone and run a few tests to double check that though. I'll get back to you ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.