Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to only sync Slack handles w/o managing channel topics #24

Open
m3co-code opened this issue Nov 18, 2024 · 1 comment
Open

Comments

@m3co-code
Copy link

Hey @timoreimann :-)

Thanks for the nice lib, still in active use ofc.

Right now it doesn't seem to be possible to only leverage the user handles for the oncall groups, w/o the tool to also sync the channel topic.

The guard for a slack channel being present when executing the sync in https://github.com/timoreimann/pdsync/blob/master/syncer.go#L132 is the culprit imho. To make it through the guard a channel needs to be specified and once a channel is configured the template must not be empty.

I might come around the next days / few weeks to (re)add the feature.

@timoreimann
Copy link
Owner

Sounds totally reasonable. Happy to review any PRs. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants