Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing comma will cause invalid layout #29

Closed
ianfhunter opened this issue Jul 13, 2017 · 3 comments
Closed

Trailing comma will cause invalid layout #29

ianfhunter opened this issue Jul 13, 2017 · 3 comments

Comments

@ianfhunter
Copy link

Example:

{
  "default": {
    "entry": "vertical",
    "layout": ["echo Hello", "echo World",]
  },
  "otherlayout": ["echo Hyper", "echo Term"]
}

If I have left a trailing , in my layout - which i generally do out of habit with json, in case i need to go back and append fields - i don't have to worry about errors of missing commas.

If i include it in layout, it invalidates the layout and hyperlayout won't set up my layout.

It's a minor issue, but I imagine that other people are affected by it too.

@philoserf
Copy link

This is expected. The format of the configuration file is JSON. This example does not validate as JSON.

@timolins timolins closed this as completed Jan 9, 2018
@philoserf
Copy link

for the record: the problem in the example's JSON format is the comma after "echo World".

@timolins
Copy link
Owner

timolins commented Jan 9, 2018

Thanks for pointing that out, @philoserf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants