Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks are not automatically invoked on Windows #17

Closed
stereokai opened this issue Dec 14, 2016 · 4 comments
Closed

Tasks are not automatically invoked on Windows #17

stereokai opened this issue Dec 14, 2016 · 4 comments

Comments

@stereokai
Copy link

The fix is to change

function runCommand(uid, cmd) {
  window.rpc.emit('data', {
    uid,
    data: ` ${cmd}\n`
  })
}

To this:

function runCommand(uid, cmd) {
  window.rpc.emit('data', {
    uid,
    data: ` ${cmd}\n\r`
  })
}

I'm not sure how it would affect Mac/Linux though, and then do we need to check for current OS environment

@timolins
Copy link
Owner

timolins commented Dec 14, 2016

Makes sense! Will give it a try on my Mac as soon as I can.

@stereokai
Copy link
Author

Awesome! 🙌

timolins added a commit that referenced this issue Dec 22, 2016
- Better session detection (d4b6723)
- Commands should run on Windows (3ef9f8c) #17
- Ignore empty commands (e78b69a) #13
@colinbate
Copy link

I'm not sure whether this is due to a new version of Hyper (1.3.2), but this is now "broken". First off, it should have been \r\n (note the \r first). But even that seems to cause issues now. The second "enter" key gets sent to the session. I was running some servers which are setup to quit upon any key stroke in the console, and they were being run and then immediately quit because of an extra "enter" key being sent to them.

@colinbate
Copy link

Perhaps Hyper is being clever about which line ending to send based on OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants