Remove some cagg_migrate test flakiness #7339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During some tests on timescale#7104 I've noticed some flakiness on Continuous Aggregates migration tests due to some output ordering. Fixed it by explicity order policies by their IDs.
fabriziomello
added
continuous_aggregate
flaky-test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7339 +/- ##
==========================================
+ Coverage 80.06% 82.20% +2.13%
==========================================
Files 190 217 +27
Lines 37181 38850 +1669
Branches 9450 10010 +560
==========================================
+ Hits 29770 31937 +2167
+ Misses 2997 2918 -79
+ Partials 4414 3995 -419 ☔ View full report in Codecov by Sentry. |
kpan2034
approved these changes
Oct 11, 2024
mkindahl
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some tests on #7104 I've noticed some flakiness on Continuous Aggregates migration tests due to some output ordering.
Fixed it by explicity order policies by their IDs.
Disable-check: force-changelog-file