Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click events don't work with jQuery 1.8 #58

Open
thsur opened this issue Oct 24, 2012 · 1 comment
Open

Click events don't work with jQuery 1.8 #58

thsur opened this issue Oct 24, 2012 · 1 comment

Comments

@thsur
Copy link

thsur commented Oct 24, 2012

Scenario:
Running the "History of Idaho" demo with jQuery 1.8.2 & jQueryUI 1.8.23

What:
Descriptions don't show up when clicking on a timeline item.

Issue:
tg.TG_TimelinePlayer.eventModal isn't called because event isn't bound
at TG_TimelineView:558

Possible solution:
Change
.delegate(CONTAINER + " .timeglider-timeline-event", CLICKORTOUCH, function () {
to
.delegate(".timeglider-timeline-event", CLICKORTOUCH, function () {
or
.on(CLICKORTOUCH, ".timeglider-timeline-event", function () {

@timeglider
Copy link
Owner

The real reason for this was that we added Modernizr
as a dependency, but forgot to update the host HTML
files. The CLICKORTOUCH string would be "click" in
normal (PC) browsers, and "touchstart" on touch enabled
devices — so this string wasn't being properly defined.
So, just make sure now to add modernizr.js (or a custom
version of it) into the element. I'm actually going
to remove this as a true dependency, and have this
default to "click" or be called from the widget options,
optionally.

FYI, all Timeglider widget code has been moved off of
Github, and is now living on our site at timeglider.com/widget
(Past commits are still here on github)

You can email me directly at [email protected] with
questions or ideas.

On Tue, Oct 23, 2012 at 6:05 PM, thsur [email protected] wrote:

Scenario:
Running the "History of Idaho" demo with jQuery 1.8.2 & jQueryUI 1.8.23

What:
Descriptions don't show up when clicking on a timeline item.

Issue:
tg.TG_TimelinePlayer.eventModal isn't called because event isn't bound
at TG_TimelineView:558

Possible solution:
Change
.delegate(CONTAINER + " .timeglider-timeline-event", CLICKORTOUCH,
function () {
to
.delegate(".timeglider-timeline-event", CLICKORTOUCH, function () {
or
.on(CLICKORTOUCH, ".timeglider-timeline-event", function () {


Reply to this email directly or view it on GitHubhttps://github.com//issues/58.


founder / lead developer
Timeglider
http://timeglider.com
[email protected]
twitter @timeglider
208.850.8512


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants