Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

details modal position #12

Open
mlooney opened this issue Jul 6, 2011 · 9 comments
Open

details modal position #12

mlooney opened this issue Jul 6, 2011 · 9 comments

Comments

@mlooney
Copy link

mlooney commented Jul 6, 2011

the details modal displayed when an event is clicked shows up in the upper left corner of the main timeline view, and is unclose able (though details and links are visible)
@timeglider
Copy link
Owner

Can you email me a screen shot as well as some info about the browser(s) it's happening on? [email protected]

@mlooney
Copy link
Author

mlooney commented Jul 6, 2011

safari 5.1 (7534.48.3)

https://skitch.com/mlooney/feqc7/skitched-20110706-150526

@timeglider
Copy link
Owner

Are you using a .min file or all the <script> tags? I don't see it happening on Safari for me. Do you have it on the web somewhere that I can see?

@mlooney
Copy link
Author

mlooney commented Jul 6, 2011

not anywhere you can see, but i'm using the min file thusly


-content_for :append_head do
  =stylesheet_link_tag '/js/timeglider/Timeglider.css'
  =javascript_include_tag "/js/timeglider.min.js"

#timeglider.span-18.last


:javascript
  $(document).ready(function() {
    var tg1 = $('#timeglider').timeline({
      'data_source': '/properties/property_report.json'
    })  
    })

yielding


    <link href="/stylesheets/blueprint/screen.css?1309359443" media="screen" rel="stylesheet" type="text/css" />
    <link href="/stylesheets/formtastic.css?1309359443" media="screen" rel="stylesheet" type="text/css" />
    <link href="/stylesheets/formtastic_changes.css?1309359443" media="screen" rel="stylesheet" type="text/css" />
    <link href="/stylesheets/blueprint/print.css?1309359443" media="print" rel="stylesheet" type="text/css" />
    <!--[if lt IE 8]>
      <link href="/stylesheets/blueprint/ie.css?1309359443" media="screen, projection" rel="stylesheet" type="text/css" />
    <![endif]-->
    <link href="/stylesheets/blueprint/plugins/fancy-type/screen.css?1309359443" media="screen, projection" rel="stylesheet" type="text/css" />
    <link href="/stylesheets/jquery-ui/smoothness/jquery-ui-1.8.14.custom.css?1308394488" media="screen" rel="stylesheet" type="text/css" />
    <script src="/javascripts/jquery.js?1309465776" type="text/javascript"></script>
    <script src="/javascripts/jquery-ui.js?1309468289" type="text/javascript"></script>
    <script src="/javascripts/jquery_ujs.js?1309465779" type="text/javascript"></script>
    <script src="/javascripts/application.js?1309895086" type="text/javascript"></script>
    <meta name="csrf-param" content="authenticity_token"/>
    <meta name="csrf-token" content="derp/Gs="/>
    <link href="/js/timeglider/Timeglider.css?1309976704" media="screen" rel="stylesheet" type="text/css" />
    <script src="/js/timeglider.min.js?1309980098" type="text/javascript"></script>
</head>
<body><html><etc>
 <div class='span-17 colborder' id='content'>
      <div class='span-18 last' id='timeglider'></div>
      <script>
        //<![CDATA[
          $(document).ready(function() {
            var tg1 = $('#timeglider').timeline({
              'data_source': '/properties/property_report.json'
            })
            })
        //]]>
      </script>
    </div>

@timeglider
Copy link
Owner

I might have had a botched build as I was creating an alternate
(full-window) modal alternative; sounds like the modal is positioning where
the large one is meant to position.

What version of jQuery are you using?

I've attached a brand new min file (on Github too) See if that fixes it.

@mlooney
Copy link
Author

mlooney commented Jul 6, 2011

1.6

@mlooney mlooney closed this as completed Jul 6, 2011
@mlooney mlooney reopened this Jul 6, 2011
@mlooney
Copy link
Author

mlooney commented Jul 6, 2011

jquery 1.6.1, tried the github .min file, no change. jquery-ui 1.8.8 fwiw

@timeglider
Copy link
Owner

okay ------ this really helps. I'll look into it further!

@timeglider
Copy link
Owner

Hi McLain
Sorry I've fallen off the Github planet for a while: Are you still having this issue? I can see that in IE, the close button on details modals is 3/4 concealed — but the positioning seems to work for me, and it's closable.

I'm planning to turn that into a more straightforward

x
element rather than one with the "fancybox" close button...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlooney @timeglider