Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Droprows optimization #5

Open
bertrandlalo opened this issue Nov 21, 2019 · 0 comments
Open

Droprows optimization #5

bertrandlalo opened this issue Nov 21, 2019 · 0 comments
Assignees
@bertrandlalo
Labels
good first issue Good for newcomers optimization Reduce processing time

Comments

@bertrandlalo
Copy link
Member

bertrandlalo commented Nov 21, 2019 •
edited
Loading

split

timeflux_dsp/timeflux_dsp/nodes/filters.py

Line 85 in 2e547ee

self.i.data, self._previous = np.split(self.i.data, [n - remaining])

Find a faster way to split the data than numpy.split.

concat

timeflux_dsp/timeflux_dsp/nodes/filters.py

Line 81 in 2e547ee

self.i.data = pd.concat([self._previous, self.i.data], axis=0, sort=True)

Find a faster way than pandas.concat

... or rethink this node to make it faster, insofar as it'll be used very often.
@bertrandlalo bertrandlalo self-assigned this Nov 21, 2019
@bertrandlalo bertrandlalo added the optimization Reduce processing time label Nov 21, 2019
@bertrandlalo bertrandlalo added the good first issue Good for newcomers label May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertrandlalo bertrandlalo

Labels
good first issue Good for newcomers optimization Reduce processing time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bertrandlalo