Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is not aborted if an error occurs #8

Open
edmorley opened this issue Mar 1, 2021 · 0 comments
Open

Build is not aborted if an error occurs #8

edmorley opened this issue Mar 1, 2021 · 0 comments

Comments

@edmorley
Copy link
Contributor

edmorley commented Mar 1, 2021

If an error occurs during the compile of this buildpack, the build continues on regardless rather than failing, since the bash error on exit mode is not enabled.

For improved reliability, it would be great to add a set -e, or even better, set -euo pipefail.

See also:
http://redsymbol.net/articles/unofficial-bash-strict-mode/

Many thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant