Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make testbenches selftesting in CI #302

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Make testbenches selftesting in CI #302

wants to merge 6 commits into from

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Nov 21, 2024 •
edited
Loading

Description

Make testbenches selftesting by:

  1. Exit with the right error code
  2. Comparing the output with the expected result

Fixes # (issues)

Type of change

  • Feature (non breaking change which adds functionality)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history

@dehanj dehanj force-pushed the make_tb_selftesting branch 2 times, most recently from e32f413 to dd20154 Compare November 22, 2024 12:51
@dehanj dehanj changed the title Make tb selftesting Fix timer core bug + testbenches selftesting in CI Nov 22, 2024
@dehanj dehanj marked this pull request as ready for review November 22, 2024 12:52
@dehanj dehanj changed the title Fix timer core bug + testbenches selftesting in CI Make testbenches selftesting in CI Nov 22, 2024
@dehanj
tb: Make tb_tk1.v selftesting
5dc354c 
- Exit with the right error code
@dehanj
tb: make tb_tk1_spi_master.v selftesting
c7fd598 
- Compare against expected value
- Exit with the correct error code
@dehanj
tb: make touch_sense selftesting
8e8aa7e 
- Check for expected word
- Exit with the right error code
@dehanj
tb: make trng selftesting
aa5608b 
- Exit with the right error code
@dehanj
tb: make uart selftesting
6bdd038 
- Exit with the right exit code
@dehanj
CI: Run testbenches in CI
4e7c511 
- Comment out uds testbench since it is broken
@dehanj dehanj linked an issue Nov 22, 2024 that may be closed by this pull request
Make testbenches self testing, and with correct exit code #185
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthornblad jthornblad Awaiting requested review from jthornblad

@agren agren Awaiting requested review from agren

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make testbenches self testing, and with correct exit code
1 participant
@dehanj