Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup 7 remaining integration test failures #2021

Open
nvkelso opened this issue Dec 2, 2021 · 1 comment
Open

Cleanup 7 remaining integration test failures #2021

nvkelso opened this issue Dec 2, 2021 · 1 comment

Comments

@nvkelso
Copy link
Member

nvkelso commented Dec 2, 2021

Down to just 8 failures (down from 60)!

FAIL: test_cycleway_with_international_route (integration-test.1170-very-early-paths-and-bike-routes.VeryEarlyPathsAndBikeRoutes)
AssertionError: Did not find feature including properties {'kind': 'path', 'is_bicycle_related': True, 'bicycle_network': 'icn'} (because layer 'roads' was empty)

======================================================================
FAIL: test_path_with_international_route (integration-test.1170-very-early-paths-and-bike-routes.VeryEarlyPathsAndBikeRoutes)
AssertionError: Did not find feature including properties {'kind': 'path', 'walking_network': 'iwn'} (because layer 'roads' was empty)

======================================================================
FAIL: test_path_with_national_route (integration-test.1170-very-early-paths-and-bike-routes.VeryEarlyPathsAndBikeRoutes)
AssertionError: Did not find feature including properties {'kind': 'path', 'walking_network': 'nwn'} (because layer 'roads' was empty)

======================================================================
FAIL: test_full_lists_disappear_by_zoom_12 (integration-test.1194-bus-route-refs.BusRouteRefs)
AssertionError: Did not find feature including properties {'bus_network': <type 'NoneType'>, 'bus_shield_text': None} (because layer 'roads' was empty)

======================================================================
FAIL: test_driveway_nwn (integration-test.596-add-hiking-routes.AddHikingRoutes)
AssertionError: Did not find feature including properties {'kind_detail': 'service', 'kind': 'minor_road', 'walking_network': 'nwn', 'service': 'driveway'} (because layer 'roads' was empty)

======================================================================
FAIL: test_minor_road_nwn (integration-test.596-add-hiking-routes.AddHikingRoutes)
AssertionError: Did not find feature including properties {'kind_detail': 'residential', 'kind': 'minor_road', 'walking_network': 'nwn'} (because layer 'roads' was empty)

======================================================================
FAIL: test_service_nwn (integration-test.596-add-hiking-routes.AddHikingRoutes)
AssertionError: Did not find feature including properties {'kind_detail': 'service', 'kind': 'minor_road', 'walking_network': 'nwn'} (because layer 'roads' was empty)

Originally posted by @nvkelso in #2016 (comment)

@nvkelso nvkelso changed the title Cleanup 8 remaining integration test failures Cleanup 7 remaining integration test failures Dec 2, 2021
@peitili
Copy link
Contributor

peitili commented Dec 13, 2021

@nvkelso
I would like to point out that some recent changes introduced more integration tests failures. Attention that the linters check is important, if the linter tests failed it won't run the integration tests and may hide the problems. One we way can do is to change the settings of the repo so that each merge have to rebase master before merging. Also to have a clearer view on which commit breaks things, we might want to try squash and merge instead of merge request, otherwise the history of commit on master are interleaved with older commits from a PR once it was merged.

If we scan the master branch and use this commit as baseline cab179d it had 8 integration tests failures

then this commit 5dfc1d1 increased it to 90

then this commit d8b7dbe might be the one that increased it to 91 (cc @iandees )

and now at the time of writing the number is 92 according to #2036
it might be introduced by #2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants