feat(lane_change): use planning factor #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
requested review from
mkquda,
rej55,
kosuke55,
maxime-clem,
shmpwk,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
| @@ -452,5 +471,17 @@ void LaneChangeInterface::updateSteeringFactorPtr( | |||
| {selected_path.info.shift_line.start, selected_path.info.shift_line.end}, | |||
| {output.start_distance_to_path_change, output.finish_distance_to_path_change}, | |||
| steering_factor_direction, SteeringFactor::APPROACHING, ""); | |||
|
|
|||
| const uint16_t planning_factor_direction = std::invoke([&output]() { | |||
There was a problem hiding this comment.
Suggested change
| const uint16_t planning_factor_direction = std::invoke([&output]() { | |
| const auto planning_factor_direction = std::invoke([&output]() { |
Just for code consistency purpose.
|
mkquda
approved these changes
Dec 23, 2024
satoshi-ota
merged commit bb03595
into
feat/development-branch-planning-factor
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
PlanningFactorInterfaceto output planning factor.Related links
Parent Issue:
How was this PR tested?
movie-2024-12-23_09.42.26.mp4
Notes for reviewers
None.
Interface changes
/planing/planning_factors/lane_change_righttier4_planning_msgs/PlanningFactorArray/planing/planning_factors/lane_change_lefttier4_planning_msgs/PlanningFactorArrayEffects on system behavior
None.