Non-orthogonal coords preserve AsIs x/y variables #6206
Merged
+81
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix. Generally looks good to me.
Should this be ignored with a warning rather than with no warning? Would it be annoying? Probably it's a rare case anyway, so I think either is fine. |
It probably can't hurt to include it, so now it throws a warning like: |
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6205.
Briefly in
coord_sf(),coord_polar/radial(), the x/y variables are preserved if they both have the 'AsIs' type. I don't think there is a reasonable interpretation if just one of the variables is 'AsIs' and the other is a plain numeric.