Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Arima x13 seasonal adjusment funtions via package seasonal #176

Closed
gustavorubim opened this issue Nov 28, 2016 · 6 comments
Closed

Comments

@gustavorubim
Copy link

library(seasonal)
a <- (a ts object)
b <- seas(a)

broom::tidy(b)
Error in as.data.frame.default(x) :
cannot coerce class ""seas"" to a data.frame
In addition: Warning message:
In tidy.default(b) :
No method for tidying an S3 object of class seas , using as.data.frame

@christophsax
Copy link

I added an experimental data.frame argument to summary.seas in seasonal 1.4, which is now on CRAN. This gives you what you would get with broom::tidy.

But I see it would be probably nicer to implement an as.data.frame method, so the default tidy method would work as well, without a need for specific broom methods.

@alexpghayes
Copy link
Collaborator

Hey @christophsax I just read christophsax/seasonal#192. It looks like you have some nice tidy implementations already -- we're actually starting to encourage people to implement tidy, glance and augment in modelling packages themselves rather than broom. Would you be willing to do that with seasonal?

When people do this there's a bit of fun registering methods in case broom also gets loaded. We could help out with that if you're interested.

@christophsax
Copy link

Is it possible to do that without the need to Imports broom? Suggests would be fine.

No problem to that, but it may take a little while.

@alexpghayes
Copy link
Collaborator

It is. Planning to add some resources on how to do this in the next couple days, will let you know when I put them up.

@github-actions
Copy link

This issue has been automatically closed due to inactivity.

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants