Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "request" node package #14055

Open
1 task done
m1ga opened this issue Jun 5, 2024 · 4 comments
Open
1 task done

Replace "request" node package #14055

m1ga opened this issue Jun 5, 2024 · 4 comments
Labels
BREAKING CHANGES ⚠️ feature needs triage This issue hasn't been reviewed by maintainers

Comments

@m1ga
Copy link
Contributor

m1ga commented Jun 5, 2024

I have searched and made sure there are no existing issues for the issue I am filing

  • I have searched the existing issues

Description

For security reasons "request" should be removed in the package.json. It is used in the following places:

  • cli/lib/creator.js
  • build/lib/utils.js

fetch should be a good replacement as we are using node v18 as a minimum now.

Solution

Alternatives

Platforms

CLI

@m1ga m1ga added feature needs triage This issue hasn't been reviewed by maintainers labels Jun 5, 2024
@AbdullahFaqeir
Copy link
Contributor

I'll take this!

@cb1kenobi
Copy link
Contributor

Titanium CLI v7 requires Node.js 18 or newer, the SDK requires Node.js 16: https://github.com/tidev/titanium-sdk/blob/master/package.json#L172. We should use fetch() only if master is slated to be 13.0.0. If we plan to ship a 12.6.0, then we must use a user land package and I highly recommend undici.

@cb1kenobi
Copy link
Contributor

Bah, and wouldn't you know it, undici requires Node 18. Nevermind that.

@AbdullahFaqeir you are welcome to do the work, but we can only merge it if master becomes 13.0.0.

@AbdullahFaqeir
Copy link
Contributor

Eeeeh 🤗, I'll just do it for fun 😂, and we can all wait for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGES ⚠️ feature needs triage This issue hasn't been reviewed by maintainers
Projects
None yet
Development

No branches or pull requests

3 participants