Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra packs for Orcsoberfest Island vs. Percht Island #104

Open
mathiasbynens opened this issue Oct 19, 2020 · 11 comments
Open

Extra packs for Orcsoberfest Island vs. Percht Island #104

mathiasbynens opened this issue Oct 19, 2020 · 11 comments

Comments

@mathiasbynens
Copy link
Member

Our map data could default to showing Orcsoberfest Island all year through (since Orcsoberfest happens twice per year), except in December and January (since Winterlight Solstice takes place from December 22 to January 10 each year).

We could set up automation to update our map data periodically.

mathiasbynens added a commit that referenced this issue Oct 19, 2020
This includes only those minimap files that are needed to cover Percht Island. The markers are moved to the separate pack for now.

Ref. #83, #104.
mathiasbynens added a commit that referenced this issue Oct 19, 2020
This includes only those minimap files that are needed to cover Orcsoberfest Island. We don’t have any Orcsoberfest-specific markers for now.

Ref. #83, #104.
@mathiasbynens
Copy link
Member Author

Given that:

  • Orcsoberfest Island is accessible from the second Friday of October to the second Friday of March.
  • Percht Island is accessible from December 22 to January 10 each year.

I'd suggest something like the following:

  • On December 1st, we enable the Percht Island pack.
  • On February 1st, we enable the Orcsoberfest Island pack.

@Hunter-of-Dragoes @LeeKunTibia Let me know if you'd prefer other dates (for example, to keep Percht Island visible for slightly longer).

@mathiasbynens
Copy link
Member Author

Test commits, triggered by the new GitHub Actions:

Seems to work great!

@Hunter-of-Dragoes
Copy link

Actually, I think we need a more robust solution.

Tibia map has become dynamic more than ever. Differently from temporary map changes caused by some mini world changes and which basically consisted of adding a portal, a bridge, some stairs or other objects, now we have map areas that are completely different depending on the time of the year. In my point of view, this seasonal change should be approached on the online Mapper with the implementation of a time dimension in addition to the existing three physical dimensions (x, y and z). This means that each map layer could have, if necessary, an alternative version.

This way, we could have different versions of other places, such as the Halls of Hope at north of Thais (implemented with Forgotten Knowledge Quest) and areas affected by MWCs and events, not just the Orcsoberfest/Winterlight Solstice island.

Since we're looking into this, we could also have a version of the map with some old places which got removed from the game, this would be especially useful to point the location of removed NPCs such Elgar at the old Travora island and The Gatekeeper on Rookgaard's premium area.

Unnecessary to say that the swapping between "time dimensions" should be user-friendly both on TibiaMaps and TibiaWiki. Even though this change would make it require more time to manage the static versions of the map - which is the great majority of it - I do see good points in implementing it.

Regarding the downloadable map files, I think players should be given the options to download the Orcsoberfest version or Winterlight Solstice version. Additionally, as Mathias said, depending on the time of the year, one of them could be the default downloadable version, e.g the Winterlight Solstice version could be the default from October 21st till January 10th.

@mathiasbynens
Copy link
Member Author

I agree, that would be a nice solution. It's also a lot of work :) Orcsoberfest Island / Percht Island seemed like the more pressing issue compared to MWCs, so that's what we focused on first.

Overall, this "extra packs" functionality seems like a good fit for what you're suggesting, except that it doesn't directly express a time dimension, but can also be used for other things (e.g. marker-only packs, etc.).

#49 is an example of something that would make sense as an optional pack. The relevant markers are already in the achievements pack, but if we want to introduce a "mini world changes" pack, or even a separate mwc-thawing pack, we could do that.

We should probably add support for transparency in pack PNGs, so that we can overwrite only those pixels that need overwriting.

@LeeKunTibia
Copy link
Collaborator

LeeKunTibia commented Feb 14, 2021

Switching from Winterlight Solstice to Orcsoberfest is deleting areas of the Soul War Quest (Ebb and Flow and Claustrophobic Inferno):

7af7b01?short_path=e2a5c80#diff-e2a5c803b87b5d32b9a3cc42fd0be23936b735157cac50c0663f70500d42b00d

mathiasbynens added a commit that referenced this issue Feb 15, 2021
@mathiasbynens
Copy link
Member Author

@LeeKunTibia Thanks for catching that! Fixed.

@LeeKunTibia
Copy link
Collaborator

Found another issue caused by this: Tentugly's boat is removed when the pack is switched: 85391ae?short_path=a852e1d#diff-a852e1d457ade61101e2765b129546293153474758e997260419bf0212228e30

https://tibiamaps.io/map#33726,31189,7:1

It also affects the floors above ground because of the mast (explored using the Cyclopedia Map).

@LeeKunTibia LeeKunTibia reopened this Jun 7, 2021
@mathiasbynens
Copy link
Member Author

@mathiasbynens
Copy link
Member Author

It also affects the floors above ground because of the mast (explored using the Cyclopedia Map).

Hmm, it looks like we actually didn't have the mast explored in that version?

https://raw.githubusercontent.com/tibiamaps/tibia-map-data/72b69f2024675533bad4f0ec6a240b438841fa7e/data/floor-06-map.png

@mathiasbynens
Copy link
Member Author

944665d restores the ground floor, at least. We still need the upper floor + the mast, both of which seem to be missing @ 72b69f2.

@LeeKunTibia
Copy link
Collaborator

LeeKunTibia commented Jul 5, 2022

Here are the upper floor + mast.

Important detail: the mast is from the Cyclopedia, so it doesn't have the temporary areas in them. This may require some manual tweaking before you can properly add the maps to the packs.

Tentugly.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants