SecurityPkg: Fix memory leak in ExtendMeasurement

Signed-off-by: Wenxing Hou <[email protected]>
tianocore · Jan 26, 2024 · 3a1b51c · 3a1b51c
1 parent 9681b4f
commit 3a1b51c
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/SecurityPkg/DeviceSecurity/SpdmSecurityLib/SpdmMeasurement.c b/SecurityPkg/DeviceSecurity/SpdmSecurityLib/SpdmMeasurement.c
@@ -207,6 +207,7 @@ ExtendMeasurement (
 
   SpdmContext = SpdmDeviceContext->SpdmContext;
 
+  EventLog = NULL;
   ZeroMem (&Parameter, sizeof (Parameter));
   Parameter.location = SpdmDataLocationConnection;
   DataSize           = sizeof (MeasurementHashAlgo);
@@ -345,7 +346,8 @@ ExtendMeasurement (
         Status        = CreateDeviceMeasurementContext (SpdmDeviceContext, DeviceContext, DeviceContextSize);
         if (Status != EFI_SUCCESS) {
           SecurityState->MeasurementState = EDKII_DEVICE_SECURITY_STATE_ERROR_DEVICE_ERROR;
-          return EFI_DEVICE_ERROR;
+          Status = EFI_DEVICE_ERROR;
+          goto Exit;
         }
       }
 
@@ -399,7 +401,8 @@ ExtendMeasurement (
         Status        = CreateDeviceMeasurementContext (SpdmDeviceContext, DeviceContext, DeviceContextSize);
         if (Status != EFI_SUCCESS) {
           SecurityState->MeasurementState = EDKII_DEVICE_SECURITY_STATE_ERROR_DEVICE_ERROR;
-          return EFI_DEVICE_ERROR;
+          Status = EFI_DEVICE_ERROR;
+          goto Exit;
         }
       }
 
@@ -416,7 +419,7 @@ ExtendMeasurement (
       }
 
       DEBUG ((DEBUG_INFO, "TpmMeasureAndLogData (Measurement) - %r\n", Status));
-      return Status;
+      goto Exit;
     default:
       SecurityState->MeasurementState = EDKII_DEVICE_SECURITY_STATE_ERROR_UEFI_UNSUPPORTED;
       return EFI_UNSUPPORTED;
@@ -475,6 +478,10 @@ ExtendMeasurement (
 
     DEBUG ((DEBUG_INFO, "TpmMeasureAndLogData (Dynamic) - %r\n", Status));
   }
+Exit:
+  if (EventLog != NULL) {
+    FreePool(EventLog);
+  }
 
   return Status;
 }