Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt-PT locale has munged recipientFmtToken key #398

Open
cleidigh opened this issue Mar 30, 2023 · 5 comments
Open

pt-PT locale has munged recipientFmtToken key #398

cleidigh opened this issue Mar 30, 2023 · 5 comments
Assignees
Labels
bug Something isn't working file naming translations
Milestone

Comments

@cleidigh
Copy link
Collaborator

cleidigh commented Mar 30, 2023

The recipientFmtToken properties key was translated somehow causing getString exception error.

See discussion with @robsonware in

@cleidigh

@cleidigh cleidigh self-assigned this Mar 30, 2023
@cleidigh cleidigh added bug Something isn't working file naming translations labels Mar 30, 2023
@cleidigh cleidigh added this to the v12.0.3 milestone Mar 30, 2023
@cleidigh
Copy link
Collaborator Author

@robsonware
I posted b8 with the fix.
In case it was not obvious, you can always use the English tokens regardless of the current locale. Then you can use the native token names for the current locale.

You were trying to use ${destinatário} which had the bad key.
I am really happy you are using the native tokens !
That is what I always intended.
Also noticed the ui is badly stretched, have to address that.
The beta:
https://github.com/thundernest/import-export-tools-ng/blob/v12.0.3/xpi/import-export-tools-ng-12.0.3-b8-tb.xpi

Tudu azul agora
@cleidigh

@robsonware
Copy link

Nice work sir! May the fourth be with you.

Você é o cara!

@cleidigh
Copy link
Collaborator Author

@robsonware
Muito obrigado voce.
When I got to some improvements to the PT ui, can I ping you for suggestions?
@cleidigh

@robsonware
Copy link

Yes, you can!

@cleidigh
Copy link
Collaborator Author

@robsonware
Excellent!
BTW reviews on the website are always appreciated %-)
@cleidigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working file naming translations
Projects
None yet
Development

No branches or pull requests

2 participants