Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for any type of headers that need to be included in requests to the Prometheus API #16

Open
harryfallows opened this issue Jul 30, 2021 · 0 comments
Labels
enhancement New feature or request input wanted Comment if you want this feature

Comments

@harryfallows
Copy link
Collaborator

harryfallows commented Jul 30, 2021

During the resolution to issue #14, the idea was floated that instead of just supporting Authorization headers, the exporter should support all types of headers for calling the Prometheus API. So, as opposed to key-value pairs of Prometheus instance identifiers and Authorization header values, the input file would consist of identifiers mapping to many header key-value pairs.

Example:

  • Current state of input file:
<prometheus-instance>: <authorization-header-value>
<another-prometheus-instance>: <authorization-header-value>
  • Proposed state of input file:
<prometheus-instance>: 
        Authorization: <authorization-header-value> 
        <another-header>: <another-value>
<another-prometheus-instance>:
        Authorization: <authorization-header-value> 
        <another-header>: <another-value>
        <another-header>: <another-value>

We decided that this would not be implemented at this moment, however, if anyone were to require it we would reconsider. Please comment below if this is something you require!

@harryfallows harryfallows added enhancement New feature or request input wanted Comment if you want this feature labels Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request input wanted Comment if you want this feature
Projects
None yet
Development

No branches or pull requests

1 participant