Skip to content
This repository has been archived by the owner on Apr 21, 2024. It is now read-only.

Styling problem beyond screen edge/Header appears #24

Open
emrahc opened this issue Feb 4, 2021 · 2 comments
Open

Styling problem beyond screen edge/Header appears #24

emrahc opened this issue Feb 4, 2021 · 2 comments

Comments

@emrahc
Copy link

emrahc commented Feb 4, 2021

Hello i use expo react native latest sdk.
When component in cropping mode it exceeds screen

IMG_0041

And header doesn't disappear. I tried to style component but no luck

Any ideas?

Thanks in advance

@thomas-coldwell
Copy link
Owner

Hi will try have a look at this today, I think some time just needs to be spent making the styling more responsive.

Could you let me know what device that screenshot is from so I can test it out?

Cheers!

@emrahc
Copy link
Author

emrahc commented Feb 6, 2021

Iphone 6, but i faced with same problem in other phones too(android,different screen sizes) I solved the issues via changing code.If there is safeareaview in parent components it causes extra space in ImageEditor. I changed safeareview to regular view in ImageEditor.tsx file and changed styles of Crop(i try to manipulate because i need only crop and only one done button) mode. But i noticed another bug with horizontal images.

image
When i drag selection grid like below

image

image
image

It pushes selection grid below picture causes error. No problem with square or vertical pictures because no space below the picture.Now i try to convery your package to only crop with one control bar(any help would be great). Developing a selection grid is too much for me now, I would like to help but i need time.

Thanks for that great editor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants