This repository has been archived by the owner on Apr 21, 2024. It is now read-only.
feat: option translate labels #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Agreed this is definitely needed to support multiple languages. Just having a look through your code and I see you have put the variable bits of text into state - was this done on purpose over just passing them down as props from the parent component? |
example/App.tsx
Outdated
| @@ -68,6 +68,17 @@ export default function App() { | |||
| console.log(result); | |||
| }} | |||
| throttleBlur={false} | |||
| textTranslateOptions={{ | |||
There was a problem hiding this comment.
I think a better name might be customLabels ?
|
I changed textTranslateOptions to customLabelsOptions. I found it easier to use a state than to pass it directly as property. |
|
Are you going to merge this? :) |
|
Hi just wanted to ask when this is going to be merged ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #17
What do you think of this implementation, so it can be translated into any language!