Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment-tag doesn’t work anymore #397

Closed
hanspagel opened this issue Oct 15, 2024 · 5 comments · Fixed by #409
Closed

comment-tag doesn’t work anymore #397

hanspagel opened this issue Oct 15, 2024 · 5 comments · Fixed by #409

Comments

@hanspagel
Copy link

hanspagel commented Oct 15, 2024

We just recently upgraded to thollander/actions-comment-pull-request@v3, since then comments are added again and again and the comment-tag is ignored. 🫨 We’re switching back to v2, but any idea what we’re doing wrong?

Example PR: scalar/scalar#3236
Our GHA workflow: https://github.com/scalar/scalar/blob/main/.github/workflows/ci.yml#L288-L296

@koppor
Copy link

koppor commented Oct 18, 2024

Underscore vs. dash issue - the README.md is inconsistent:

image

image


I would propose to update the README.md to consistently use the new dash (done at #399) - or release a v4 and reverting to underscore.

@nitrocode
Copy link

nitrocode commented Oct 21, 2024

The title of the issue is a little confusing.

Is it that comment_tag input doesn't work anymore and the new input is comment-tag so if the new input is used, the issue is resolved ?

Maybe the old inputs can be added back in but as deprecated ?

inputs:
  comment_tag:
    deprecationMessage: 'This option is removed. Use comment-tag instead.'
  comment-tag:
    description: 'A tag on your comment that will be used to identify a comment in case of replacement.'

https://docs.github.com/en/actions/sharing-automations/creating-actions/metadata-syntax-for-github-actions#inputsinput_iddeprecationmessage

FYI introduced by

@koppor
Copy link

koppor commented Oct 21, 2024

Is it that comment_tag input doesn't work anymore and the new input is comment-tag so if the new input is used, the issue is resolved ?

Yes.

@ViacheslavKudinov
Copy link

Hi,
i think all the examples on READMe.md file have to be updated with new input names where is used kebab-case instead of current wrong ones with snake_case.

@thollander
Copy link
Owner

Hey,

Thanks for the feedbacks. Indeed there was an issue in the refactoring around logs and documentation.
Fixed in v3.0.1 and also on v3 (pointing to v3.0.1) ✅

ziegenberg added a commit to ziegenberg/opencast-admin-interface that referenced this issue Nov 29, 2024
When updating `thollander/actions-comment-pull-request` to `v3` the
underscore in `comment_tag` no longer works because now it's a dash and
we have to use `comment-tag`. The README.md was fixed with this PR
thollander/actions-comment-pull-request#397.

Signed-off-by: Daniel Ziegenberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants