-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: group algebras with sparse representation #1655
Conversation
d4cbc4f
to
2c131f3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1655 +/- ##
==========================================
+ Coverage 75.85% 75.90% +0.04%
==========================================
Files 361 361
Lines 113719 113783 +64
==========================================
+ Hits 86262 86366 +104
+ Misses 27457 27417 -40
|
Does this change allow me to work with group algebras of infinite groups as well? |
Yes:
|
This is wonderful! I will shift to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Some quick comments and questions (all nitpicks, not meant to block anything)
60f759d
to
4de570c
Compare
Thanks for the comments. I think I addressed them all. I also removed the |
Due to popular demand, group algebras with sparse representation (aka "don't crash with large groups"). Needs some work/clean up:
@royess this might interest you. It is similar to your approach.
Small todo:
FG(::Dict)
constructor.