Fix factor #1639
Closed
Fix factor #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canonical unit for QadicRing was retuning the inv of what it should. The spec is return u s.th. x/u is canonical, so for fields u = x is legal. xxgcd and make_exact are using AA in shf/hnf
benlorenz
reviewed
Oct 9, 2024
| @@ -74,6 +74,7 @@ using Pkg | |||
|
|
|||
| import AbstractAlgebra | |||
| import AbstractAlgebra: get_cached!, @alias | |||
| import AbstractAlgebra: xxgcd, make_exact | |||
There was a problem hiding this comment.
Suggested change
| import AbstractAlgebra: xxgcd, make_exact |
These don't seem to exist
┌ Hecke
│ WARNING: could not import AbstractAlgebra.xxgcd into Hecke
│ WARNING: could not import AbstractAlgebra.make_exact into Hecke
└
and are not needed for this fix?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1639 +/- ##
==========================================
+ Coverage 75.80% 75.82% +0.01%
==========================================
Files 361 361
Lines 113700 113701 +1
==========================================
+ Hits 86192 86215 +23
+ Misses 27508 27486 -22
|
|
On Wed, Oct 09, 2024 at 01:53:23AM -0700, Benjamin Lorenz wrote:
@benlorenz commented on this pull request.
> @@ -74,6 +74,7 @@ using Pkg
import AbstractAlgebra
import AbstractAlgebra: get_cached!, @alias
+import AbstractAlgebra: xxgcd, make_exact
```suggestion
```
These don't seem to exist
```
┌ Hecke
│ WARNING: could not import AbstractAlgebra.xxgcd into Hecke
│ WARNING: could not import AbstractAlgebra.make_exact into Hecke
└
```
and are not needed for this fix?
not needed and not quite sure why they are in. They were part of a
different PR
…
--
Reply to this email directly or view it on GitHub:
#1639 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
|
cleaned it up in #1640 |
|
Merged via #1640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if neccessary I can remove the spurious import. Should fix Oscar #4170