Add Simon's constructor for elliptic curves. #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thofma
reviewed
Aug 23, 2023
test/EllCrv/EllCrv.jl
Outdated
| @testset "additional constructors" begin | ||
| R, (x, y) = polynomial_ring(QQ, [:x, :y]) | ||
| f = y^2 - x^3 - 3*x^2 + 7*x - 4 | ||
| Hecke.elliptic_curve(f, x, y) |
There was a problem hiding this comment.
Suggested change
| Hecke.elliptic_curve(f, x, y) | |
| elliptic_curve(f, x, y) |
thofma
reviewed
Aug 23, 2023
test/EllCrv/EllCrv.jl
Outdated
| kt = fraction_field(pt) | ||
| R, (x, y) = polynomial_ring(kt, [:x, :y]) | ||
| f = y^2 - x^3 - 3*t*x^2 + 7*x - 4*t^2 - 3 | ||
| Hecke.elliptic_curve(f, x, y) |
There was a problem hiding this comment.
Suggested change
| Hecke.elliptic_curve(f, x, y) | |
| elliptic_curve(f, x, y) |
|
A docstring would be nice |
Really? I was afraid, this would not be appreciated because of too many documented methods of the same function. But I can try to add it. Btw: It seems you already had similar functionality. Is that true? |
|
At the moment there are two methods documented, so adding another won't hurt. And I don't think we have anything that accepts bivariate polynomials. |
simonbrandhorst
approved these changes
Aug 23, 2023
|
Thank you. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
+ Coverage 74.38% 74.41% +0.02%
==========================================
Files 346 346
Lines 110720 110743 +23
==========================================
+ Hits 82361 82404 +43
+ Misses 28359 28339 -20
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @simonbrandhorst