From e2ab622909c3297ba02eac812c3ad0854835ec7b Mon Sep 17 00:00:00 2001 From: StevellM Date: Tue, 29 Oct 2024 08:41:10 +0100 Subject: [PATCH] remove comment and add new ambiguous example --- src/QuadForm/Quad/GenusRep.jl | 6 +----- test/QuadForm/QuadBin.jl | 6 +++++- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/QuadForm/Quad/GenusRep.jl b/src/QuadForm/Quad/GenusRep.jl index 5d4613439a..ac5f34e35a 100644 --- a/src/QuadForm/Quad/GenusRep.jl +++ b/src/QuadForm/Quad/GenusRep.jl @@ -2135,7 +2135,7 @@ end function _lattice_to_binary_quadratic_form(L::QuadLat) M = absolute_basis_matrix(L) # This corresponds to a basis of L - @assert nrows(M) == 2 && ncols(M) == 2 + @assert nrows(M) == 2 G = gram_matrix(ambient_space(L), M) GG = change_base_ring(FlintQQ, G) d = denominator(GG) @@ -2284,10 +2284,6 @@ function automorphism_group_generators(g::QuadBin{ZZRingElem}) f = matrix(ZZ, 2, 2, [a, b, n, -a]) push!(gens, t* f * inv(t)) end - # Stevell can make sense of this: -# if is_ambiguous && !(a==0 ||(a != 0 && c ==0 && b % (2*a) == 0)) -# error("missing case") -# end for T in gens @assert _action(g, T) == g end diff --git a/test/QuadForm/QuadBin.jl b/test/QuadForm/QuadBin.jl index 31afa1a3a5..bddfacce07 100644 --- a/test/QuadForm/QuadBin.jl +++ b/test/QuadForm/QuadBin.jl @@ -216,7 +216,11 @@ g = binary_quadratic_form(-4, 3, 0) gens = automorphism_group_generators(g) - @test gens == [ZZ[-1 0;0 -1], ZZ[-4 3; -5 4]] + @test gens == [ZZ[-1 0; 0 -1], ZZ[-4 3; -5 4]] + + g = binary_quadratic_form(-4, 16, 0) + gens = automorphism_group_generators(g) + @test gens == [ZZ[-1 0; 0 -1], ZZ[-1 4; 0 1]] g = binary_quadratic_form(1, 2, 0) gens = automorphism_group_generators(g)