Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing through Req opts? #24

Open
cigrainger opened this issue Feb 21, 2024 · 3 comments
Open

Enable passing through Req opts? #24

cigrainger opened this issue Feb 21, 2024 · 3 comments

Comments

@cigrainger
Copy link
Contributor

We have a need for ipv6 (fly.io flycast) to connect to ollama. Would you be up for a PR that allows passing through Req options to the adapter? (Much like how Req itself allows passing connect_options through to Finch). request_options on the chat_completion config should do it.

@thmsmlr
Copy link
Owner

thmsmlr commented Feb 22, 2024

Yup sounds reasonable

@cigrainger
Copy link
Contributor Author

I actually think this might just be a documentation fix -- seems like http_options can be passed through and override the config? I'll check it out.

@thbar
Copy link
Collaborator

thbar commented Mar 2, 2024

Just wanted to chime in to remind/state that Req has some built-in testing facilities over there: https://hexdocs.pm/req/Req.Test.html#module-example (in addition to other possibilities for testing).

It would be great to ensure that someone writing test against instructor_ex can stub Req via the permitted options (although one can also "Mox" above instructor_ex too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants