Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 compatibility #8

Closed
e-com-presta opened this issue Dec 29, 2022 · 1 comment
Closed

PHP 8.2 compatibility #8

e-com-presta opened this issue Dec 29, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@e-com-presta
Copy link
Contributor

Message: explode(): Passing null to parameter #2 ($string) of type string is deprecated
Location: modules/collectlogs/classes/Settings.php line 192

@getdatakick
Copy link
Contributor

Method Settings::setEmailAddresses now ensures that entry in tb_configuration table contains either valid string, or does not exists at all. Therefore, null value should never be stored in tb_configuration table for COLLECTLOGS_NEW_ERRORS_EMAIL configuration key.

However, previous version of module did not do this check, so in some cases null can actually be stored inside db table. Hence this issue.

There is very simple workaround -- simply resave module settings.

@getdatakick getdatakick added the bug Something isn't working label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants