Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The TX power from ADR is not used #17

Open
terrillmoore opened this issue Mar 12, 2017 · 0 comments
Open

The TX power from ADR is not used #17

terrillmoore opened this issue Mar 12, 2017 · 0 comments

Comments

@terrillmoore
Copy link
Member

Although there is an elaborate mechanism for ADR in the LMIC code, LMIC.adrTxPow (which repersents the ADR adjusted TX power in dBm) is not used.

Transmit power is controlled (in radio.c) by LMIC.txpow. For US915, LMIC.txpow is unconditionally set to 26dBm for 500kHz channels, and to 30dBm for 125kHz channels.

(Further muddling things, radio.c for the sx1276 appears to only set the power to a max of 10 dBm -- it doesn't seem to correctly program the 20dBm boost mode. In any case, the setting of LMIC.txpow has basically no effect, because both values are greater than 15, and any value greater than 15 is mapped to 15 by radio.c.)

So it appears that the Tx Power is basically fixed (for US915), and the only thing that ADR can really adjust is data rate.

frankleonrose pushed a commit that referenced this issue Dec 11, 2017
Convert #if's on config variables to #if defined for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant