Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip count down when players left #428

Merged

Conversation

Dashboy1998
Copy link
Contributor

Context

Choices

  • Changed to match behavioral of auto reboot.

Test instructions

Auto reboot

  • Set AUTO_REBOOT_CRON_EXPRESSION close to your current time
  • Set AUTO_REBOOT_ENABLED to true
  • Set AUTO_REBOOT_EVEN_IF_PLAYERS_ONLINE to true
  • Set AUTO_REBOOT_WARN_MINUTES to 5

Players in game and messages

Join the server and verify that the server restarts in 5 minutes after the cronjob has started and you receive messages for 5, 2, 1 minutes, and 30, 10 seconds.

Players leave game during countdown

Join the server and once the cronjob starts leave the game and verify it restarts on the minute after you left.

Auto Update

  • Set UPDATE_CRON_EXPRESSION close to your current time
  • Set AUTO_UPDATE_ENABLED to true
  • Set AUTO_REBOOT_WARN_MINUTES to 5
  • Set UPDATE_ON_BOOT to true
  • After the server starts change the buildId on line 33 in the file `palworld\steamapps\appmanifest_2394010.acf`` to any other value (for example 63707356556294349890)

Players in game and messages

Join the server and verify that the server restarts in 5 minutes after the cronjob has started and you receive messages for 5, 2, 1 minutes, and 30, 10 seconds.

Players leave game during countdown

Join the server and once the cronjob starts leave the game and verify it restarts on the minute after you left.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@Dashboy1998 Dashboy1998 marked this pull request as ready for review February 22, 2024 07:34
Copy link
Owner

@thijsvanloef thijsvanloef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not seem to work, even if I enter auto reboot warn minutes, the server will shutdown instantly every time, even if players are online

Copy link
Owner

@thijsvanloef thijsvanloef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works as expected! Thanks for the contributions :D

@thijsvanloef thijsvanloef merged commit 62aad6b into thijsvanloef:main Feb 22, 2024
10 checks passed
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
…when-players-left

Skip count down when players left
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto reboot and auto update when players leave
2 participants