Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added exit for compile settings failure #383

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Added exit for compile settings failure #383

merged 3 commits into from
Feb 14, 2024

Conversation

Dashboy1998
Copy link
Contributor

Context

  • Compile-settings.sh has a

Choices

  • I believe it should exit on a failure

Test instructions

  1. Make sure it works as expected
  2. Force an exit: chmod 444 palworld/Pal/Saved/Config/LinuxServer/PalWorldSettings.ini

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@thijsvanloef thijsvanloef merged commit e94a651 into thijsvanloef:main Feb 14, 2024
8 checks passed
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
@thijsvanloef
Merge pull request thijsvanloef#383 from Dashboy1998/exit-on-compile-…
8c6a7d4 
…settings-failure

Added exit for compile settings failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dashboy1998 @thijsvanloef