Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes to rcon.yaml password #258

Merged

Conversation

BongoEADGC6
Copy link
Contributor

@BongoEADGC6 BongoEADGC6 commented Feb 1, 2024

Quotes allow for special characters to be used in the password field for the rcon config yaml.

Context

  • Allow or the use of special characters in rcon and admin passwords

Choices

  • This is what yaml allows

Test instructions

Tested with and without special characters.

  1. Set env vars
  2. Run EOL text insertion
  3. run rcon-cli to check errors

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README. (Documentation shouldn't be required as there is no documentation stating a limitation.)
  • I've not introduced breaking changes.

Single quotes allow for special characters to be used in the password field for the rcon config yaml.
@BongoEADGC6 BongoEADGC6 changed the title Add single quotes to rcon.yaml password Add quotes to rcon.yaml password Feb 1, 2024
@Dashboy1998
Copy link
Contributor

Dashboy1998 commented Feb 1, 2024

What special characters currently don't work?

  • ADMIN_PASSWORD=sp!@#$%^*()!1-_=+[]{}`~:;<>,.?SPACE WORD

The above works in main now. Looks like &/\ don't work in either.

Copy link
Owner

@thijsvanloef thijsvanloef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this does not change the actual string in the file, this does resolve an uncaught shellcheck error: https://www.shellcheck.net/wiki/SC2086

@thijsvanloef thijsvanloef merged commit b729ec8 into thijsvanloef:main Feb 2, 2024
4 checks passed
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
…fig-formatting

Add quotes to rcon.yaml password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants