Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to manage set_process_name for qemu.conf #21

Open
igalic opened this issue Jan 13, 2014 · 2 comments
Open

add option to manage set_process_name for qemu.conf #21

igalic opened this issue Jan 13, 2014 · 2 comments

Comments

@igalic
Copy link
Contributor

igalic commented Jan 13, 2014

After merging the qemu changes, my config is now being overridden, and the only parameter I ever touch in (set_process_name).
Can we please add it to the list options?

And while we're at it, maybe we should think about a less painful way of adding new options.

Perhaps an options hash that's passed into the Erb would be better. That way we could have closed up, dedicated namespaces for each subsystem (qemu, Xen, whathaveyou).

@thias
Copy link
Owner

thias commented Jan 13, 2014

Why not... are you thinking about something like this as the default, doing the right thing?

$sasl2_libvirt = {
  'mech_list' => 'digest-md5',
  'keytab' => '/etc/libvirt/krb5.tab',
  'sasldb_path' => '/etc/libvirt/passwd.db',
}

Then inside the template, all of the recognised keys would have their value set in the right place, and all the non-recognised ones would be output at the bottom by default?

@igalic
Copy link
Contributor Author

igalic commented Jan 13, 2014

Not sure if we should warn or fail for non-recognized ones.
But that's the general idea, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants