Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Accept PR 2: Frontend & Waiting List Integration #10416

Draft
wants to merge 6 commits into
base: v3/auto-accept
Choose a base branch
from

Conversation

dunkOnIT
Copy link
Contributor

@dunkOnIT dunkOnIT commented Dec 11, 2024

Frontend Changes

  • Move waiting list to above the accepted list if it has at least one registration || competitor_limit has been reached | auto_accept is enabled and auto_accept_disable_threshold has been reached
  • Warn an organizer if they're trying to accept a user from the Pending list while there are registrations on the Waiting List
  • Give organizers a way to toggle auto-accept on/off
  • Give organizers a way to run a bulk auto-accept
  • Automatically run bulk auto-accept when auto-accept is toggled on
    • Warn organizers this will happen, and give them an "Are you sure?" dialogue, where saying "No" will

Backend Changes

  • Auto-accept users onto waiting list when Accepted is full
    • Should they be accepted onto the waiting list if the auto-accept-cutff has been reached? No - consulted people on discord
  • Auto-accept users from waiting list if a spot becomes available in the accepted list (ie, if an attendee's status changes away from accepted
  • Add bulk auto accept class method
  • Add bulk auto accept route

@dunkOnIT
Copy link
Contributor Author

dunkOnIT commented Dec 12, 2024

Waiting list:

  • Accept a user from the waiting list if a spot becomes available on the Accepted list
  • Model Tests
    • allow auto-accepting the first position on the waiting list
  • Integration Tests
    • Trigger an auto_accept job from the competing lane if a user's status changes away from accepted

@dunkOnIT
Copy link
Contributor Author

Add to waiting list:

  • If the Accepted list is full, accept users onto the Waiting List
    • What if the auto_accept_disable threshold is reached?

@dunkOnIT
Copy link
Contributor Author

Bulk auto accept class method tests:

  • Accepts competitors from the waiting list
    • in order of waiting list
  • Accepts pending competitors
    • in order of payment
  • Accepts up to but not exceeding the competition limit
    • those not accepted follow the expected order (later on waiting list = not accepted, later payment = not accepted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant