-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3/auto accept #10415
Open
dunkOnIT
wants to merge
19
commits into
main
Choose a base branch
from
v3/auto-accept
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V3/auto accept #10415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You could have still branched off your PR but squashed your previous commits using rebase (which you can then drop after merge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #10381 - I needed to make thewca the base repo for the first PR so that the diff on the 2nd PR wouldn't be absurdly long like the last time I branched off an in-review PR.
Lots to do here, will probably just handle basic pending -> accepted case in this PR.
Implementation Thoughts
auto_accept
method on theregistration
model. I think this should ultimately be where our auto_accept logic lives, and that is what will get called even if we have multiple entry points for auto_accepting. For example:registration.auto_accept
auto_accept
on each of themThis PR
auto-accept
andauto-accept-cutoff
settings to competition tableNext PR
Later PR's
accepted
Questions: