Introduce registration version column instead of uses_v2_registrations

[FinnIckler]

To allow us to switch over to 'v3' in stages

[FinnIckler]

I'll do the form changes tomorrow afternoon

[gregorbg]

Am I crazy, or did we have some other places in the code where we explicitly pass uses_v2_registration: true?!
EDIT: Just saw your comment about the form changes, sorry. GitHub Mobile only shows the PR comments after you submitted your review...

Please do a global string search for the name of the old boolean column to confirm. I reckon some tests and factories might also need to be adjusted.

[FinnIckler]

I added the changes to the Form and CTRL-F for uses_v2_registrations only finds the migrations

[FinnIckler]

I implemented it my way to give us an easier way to switch between systems, but I get that we can always just use the rails console if needed (as it might be confusing for users)

[FinnIckler]

Again, I can't approve myself, but I'm fine with this implementation

[gregorbg]

I implemented it my way to give us an easier way to switch between systems, but I get that we can always just use the rails console if needed (as it might be confusing for users)

Making it easy to switch systems is my intention as well. But I think our interpretation of "easy" is not the same here 😅 WCAT doesn't need to know that there is a further distinction between V2 and V3. They only need one checkbox where "off = old" and "on = new". We can simply change the value of the NEW_REG_SYSTEM_DEFAULT constant in the backend, thereby controlling what this checkbox internally does.

[gregorbg]

Furthermore, I have tried to drill down the distinction between V2 and V3 in the backend even further. This is important for places where we need to decide whether a route hits the microservice or not.

Other places, for example methods that decide whether to render React or the old frontend, don' need to care whether it's V2 or V3, they only care that it's "not V1". At the end of the day, I think this facilitates migration.

[FinnIckler]

Method changes look good to me.
Technically it's always possible to switch from v1 to v3 and back again, but I don't think we need to overcomplicate the competition form like that

[gregorbg]

Method changes look good to me.

Thanks!

Technically it's always possible to switch from v1 to v3 and back again, but I don't think we need to overcomplicate the competition form like that

Both V2 and V3 are detected as "new system" in terms of the WCAT frontend, so it would be a simple matter of removing the checkbox to go from V3 to V1. The only thing that's "unintuitive" is that ticking the checkbox again would enable V2 as-is. But TBH when we are manually marking competitions as V3 we will probably hand-pick a few where we are sure that WCAT won't un-tick then re-tick them without telling us. And once we're rolling out V3 as default this will become a non-issue.

[gregorbg]

Approving on behalf of Finn and myself.