Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline images to Delegate Reports #10086

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

gregorbg
Copy link
Member

Adds the ability to directly force image uploads in a Delegate Report, instead of "butchering" it through Markdown.
Advantage 1: We can verify that a Delegate indeed uploaded images before submitting the report.
Advantage 2: We can query these images later, aggregate them, move them elsewhere without much hassle, etc.

@gregorbg
Copy link
Member Author

Pictures!

How it looks in the "Edit" interface on the website:
swappy-20241018_000909

How it looks in the rendered report (pictures are small on purpose, clicking them will open a new tab with the full-size version)
swappy-20241018_000938

@gregorbg gregorbg force-pushed the feature/dr-setup-images branch from aa7ed63 to 083aae3 Compare October 29, 2024 06:35
@FinnIckler
Copy link
Member

Missing as per Email Thread:

  • Can we also please have the guidance text added as well so delegates are prompted to write a brief setup description as well? I.e.
    Setup: [Please write a brief description of the competition set up. Photo(s) of the scrambling area and competition setup are to be uploaded using the upload button below.]
  • Can we upload image UI please be added between the 'Venue' and 'Organisation' sections as per below:

@dmint789
Copy link
Member

Missing as per Email Thread:

  • Can we also please have the guidance text added as well so delegates are prompted to write a brief setup description as well? I.e.
    Setup: [Please write a brief description of the competition set up. Photo(s) of the scrambling area and competition setup are to be uploaded using the upload button below.]
  • Can we upload image UI please be added between the 'Venue' and 'Organisation' sections as per below:

It would also be good to add text to the image upload section that says there must be at least two images showing the setup (i.e. scrambling area, competition area, waiting area (if there is one). This is necessary to ensure the WSAP is being followed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants