-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline images to Delegate Reports #10086
Open
gregorbg
wants to merge
14
commits into
thewca:main
Choose a base branch
from
gregorbg:feature/dr-setup-images
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
force-pushed
the
feature/dr-setup-images
branch
from
October 29, 2024 06:35
aa7ed63
to
083aae3
Compare
Missing as per Email Thread:
|
It would also be good to add text to the image upload section that says there must be at least two images showing the setup (i.e. scrambling area, competition area, waiting area (if there is one). This is necessary to ensure the WSAP is being followed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to directly force image uploads in a Delegate Report, instead of "butchering" it through Markdown.
Advantage 1: We can verify that a Delegate indeed uploaded images before submitting the report.
Advantage 2: We can query these images later, aggregate them, move them elsewhere without much hassle, etc.